Step2 로또(자동) #3234
Open
Step2 로또(자동) #3234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
May 17, 2023 20:20
mskangg
requested changes
May 19, 2023
Comment on lines
+20
to
+22
| - [x] 로또 구입 금액을 입력하면 구입 금액에 해당하는 로또를 발급해야 한다. | ||
| - [x] 로또 1장의 가격은 1000원이다. |
Comment on lines
+10
to
+17
| private int purchasedPrice = 0; | ||
| private List<Integer> prices = Arrays.asList( | ||
| 0, 0, 5000, 50000, 1500000, 2000000000 | ||
| ); | ||
|
|
||
| private int totalEarningPrice = 0; | ||
|
|
||
| private List<Integer> winners; |
There was a problem hiding this comment.
출력을 담당하는 View 클래스인데, 다른 상태들도 갖고있네요!
로또에서의 당첨결과, 통계는 비즈니스 도메인 클래스로 추출할 수 있어보이고, 당첨로또번호도 클래스로 분리할 수 있어보이네요 🤔
LottoOutputView 클래스는 출력의 책임만 갖고있도록 해보아요!
Comment on lines
+9
to
+13
| private final int lottoPrice = 1000; | ||
|
|
||
| private int amount; | ||
| private int lottoCount; | ||
| private List<Integer> winNumbers = new ArrayList<>(); |
There was a problem hiding this comment.
여기도 같은 리뷰입니당 :)
입력의 책임만 갖을 수 있게 리팩토링해주세용
Comment on lines
+13
to
+16
| List<Integer> mockNumbers = new ArrayList<>(); | ||
| for (int i = 1; i <= 45; i++) { | ||
| mockNumbers.add(i); | ||
| } |
There was a problem hiding this comment.
매번 리스트를 생성하곘네요 🤔
1-45 숫자를 캐싱해보는건 어떠신가요?
Comment on lines
+4
to
+5
|
|
||
| public interface NumberGenerator { |
|
|
||
| public class LotteryContainer { | ||
|
|
||
| // private NumberGenerator generator; |
Comment on lines
+12
to
+13
| private boolean isWinnerCheck = false; | ||
| private int matchCount = 0; |
There was a problem hiding this comment.
내부변수가 과연 필요한지 고민해봐야할것 같아요 🤔
평소 클래스설계를 할 때 어떤 기준으로 내부변수를 정의 하시나요??
Comment on lines
+70
to
+72
| lotto.setWinNumbers(winNumbers); | ||
|
|
||
| int matchCount = lotto.getMatchCount(); |
There was a problem hiding this comment.
lotto에서 matchCount를 꺼내 활용하는것 보단
Suggested change
| lotto.setWinNumbers(winNumbers); | |
| int matchCount = lotto.getMatchCount(); | |
| int matchCount = lotto.match(winNumbers); |
메세지를 보내어 객체지향으로 구현하시는건 어떠신가요?
Comment on lines
+20
to
+23
| for (Lottery lotto : lottoContainer.getTotalLottery()) { | ||
| System.out.println(lotto.getLottery()); | ||
| } | ||
| System.out.println(""); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 !
로또 (자동) 단계 진행하여 리뷰 요청 드립니다 !