Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Step4] 로또 수동 미션 리뷰 요청드립니다. #3252

Open
wants to merge 43 commits into
base: woonys
Choose a base branch
from
Open

[Step4] 로또 수동 미션 리뷰 요청드립니다. #3252

wants to merge 43 commits into from

Commits on May 8, 2023

  1. step2

    woony-kim committed May 8, 2023
    Configuration menu
    Copy the full SHA
    1ef4745 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2023

  1. refactor 출력 책임 -> LottoOutputView로 이관

    woony-kim committed May 9, 2023
    Configuration menu
    Copy the full SHA
    8cb1c8d View commit details
    Browse the repository at this point in the history

  2. refactor controller layer 메소드 통합

    woony-kim committed May 9, 2023
    Configuration menu
    Copy the full SHA
    29c3931 View commit details
    Browse the repository at this point in the history

  3. refactor 당첨번호 변수명 수정

    woony-kim committed May 9, 2023
    Configuration menu
    Copy the full SHA
    52c87d1 View commit details
    Browse the repository at this point in the history

  4. refactor LottoGenerator 이름 변경

    woony-kim committed May 9, 2023
    Configuration menu
    Copy the full SHA
    28e8c34 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2023

  1. refactor WinningAnalyzer 클래스 분리

    woony-kim committed May 11, 2023
    Configuration menu
    Copy the full SHA
    ffee75c View commit details
    Browse the repository at this point in the history

Commits on May 12, 2023

  1. fix WinningAnalyzer 테스트 fail 수정

    woony-kim committed May 12, 2023
    Configuration menu
    Copy the full SHA
    e88c49b View commit details
    Browse the repository at this point in the history

  2. refactor MINIMUM_MONEY 상수 라인 위치 수정

    woony-kim committed May 12, 2023
    Configuration menu
    Copy the full SHA
    23dce40 View commit details
    Browse the repository at this point in the history

  3. refactor WinningPrizes Enum 클래스로 리팩토링

    woony-kim committed May 12, 2023
    Configuration menu
    Copy the full SHA
    bdd152b View commit details
    Browse the repository at this point in the history

  4. refactor MethodSource -> given절 수정

    woony-kim committed May 12, 2023
    Configuration menu
    Copy the full SHA
    439d0b0 View commit details
    Browse the repository at this point in the history

  5. refactor methodSource 적용

    woony-kim committed May 12, 2023
    Configuration menu
    Copy the full SHA
    28c3baa View commit details
    Browse the repository at this point in the history

  6. refactor moneyTest 메소드명 수정

    woony-kim committed May 12, 2023
    Configuration menu
    Copy the full SHA
    efc0e7c View commit details
    Browse the repository at this point in the history

Commits on May 14, 2023

  1. refactor LottoNumber 일급 컬렉션 추가

    @woonys
    woonys committed May 14, 2023
    Configuration menu
    Copy the full SHA
    01b9c5b View commit details
    Browse the repository at this point in the history

Commits on May 15, 2023

  1. refactor LottoNumber 일급 컬렉션 변경

    woony-kim committed May 15, 2023
    Configuration menu
    Copy the full SHA
    8635832 View commit details
    Browse the repository at this point in the history

  2. fix 안쓰는 메소드 제거

    woony-kim committed May 15, 2023
    Configuration menu
    Copy the full SHA
    f5dcc89 View commit details
    Browse the repository at this point in the history

  3. refactor WinningNumbers 객체 포장

    woony-kim committed May 15, 2023
    Configuration menu
    Copy the full SHA
    d438a18 View commit details
    Browse the repository at this point in the history

  4. refactor methodSource 추가

    woony-kim committed May 15, 2023
    Configuration menu
    Copy the full SHA
    ab41bf6 View commit details
    Browse the repository at this point in the history

  5. feat 보너스 볼 객체 구현

    woony-kim committed May 15, 2023
    Configuration menu
    Copy the full SHA
    02b9e10 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2023

  1. Step3 - 로또(2등)

    woony-kim committed May 16, 2023
    Configuration menu
    Copy the full SHA
    9a41fa9 View commit details
    Browse the repository at this point in the history

  2. refactor LottoGame 생성자 이름 수정

    woony-kim committed May 16, 2023
    Configuration menu
    Copy the full SHA
    526bf8f View commit details
    Browse the repository at this point in the history

  3. Merge branch 'woonys' into step3

    @woonys
    woonys authored May 16, 2023
    Configuration menu
    Copy the full SHA
    01b8bc5 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2023

  1. refactor LottoNumber 정적 팩토리 메소드 시그니처 변경

    woony-kim committed May 17, 2023
    Configuration menu
    Copy the full SHA
    8295523 View commit details
    Browse the repository at this point in the history

  2. refactor prizeMoney 가독성을 위한 언더바 추가

    woony-kim committed May 17, 2023
    Configuration menu
    Copy the full SHA
    093289d View commit details
    Browse the repository at this point in the history

  3. refactor prizeMoney final 추가

    woony-kim committed May 17, 2023
    Configuration menu
    Copy the full SHA
    da4cb96 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2023

  1. refactor 컨트롤러 책임 -> LottoGame 및 OutputView로 이관

    woony-kim committed May 18, 2023
    Configuration menu
    Copy the full SHA
    34441da View commit details
    Browse the repository at this point in the history

  2. refactor 삼항연산자 수정

    woony-kim committed May 18, 2023
    Configuration menu
    Copy the full SHA
    34ffa90 View commit details
    Browse the repository at this point in the history

  3. refactor rank 변수명 수정

    woony-kim committed May 18, 2023
    Configuration menu
    Copy the full SHA
    4ff4ac2 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2023

  1. refactor WinningPrizes 내 판별 책임 -> WinningPrizeMatcher로 이관

    woony-kim committed May 21, 2023
    Configuration menu
    Copy the full SHA
    fce711d View commit details
    Browse the repository at this point in the history

  2. fix 이름 수정

    woony-kim committed May 21, 2023
    Configuration menu
    Copy the full SHA
    c5195d3 View commit details
    Browse the repository at this point in the history

  3. refactor 일급 컬렉션 LottoResult 추가

    woony-kim committed May 21, 2023
    Configuration menu
    Copy the full SHA
    d4cd565 View commit details
    Browse the repository at this point in the history

  4. fix WinningPrizeMatcher NPE 이슈 해결

    woony-kim committed May 21, 2023
    Configuration menu
    Copy the full SHA
    cbc09ed View commit details
    Browse the repository at this point in the history

  5. refactor stream 적용

    woony-kim committed May 21, 2023
    Configuration menu
    Copy the full SHA
    9df8aef View commit details
    Browse the repository at this point in the history

  6. wip2

    woony-kim committed May 21, 2023
    Configuration menu
    Copy the full SHA
    1000ed1 View commit details
    Browse the repository at this point in the history

  7. wip

    woony-kim committed May 21, 2023
    Configuration menu
    Copy the full SHA
    b55bb6d View commit details
    Browse the repository at this point in the history

  8. feat 기능 구현 완료

    woony-kim committed May 21, 2023
    Configuration menu
    Copy the full SHA
    d1924a5 View commit details
    Browse the repository at this point in the history

  9. refactor stream 적용, getXXX 메서드 이름 수정

    woony-kim committed May 21, 2023
    Configuration menu
    Copy the full SHA
    ee72b4d View commit details
    Browse the repository at this point in the history

  10. refactor 엔티티 2depth 탐색 제거

    woony-kim committed May 21, 2023
    Configuration menu
    Copy the full SHA
    3fabb64 View commit details
    Browse the repository at this point in the history

  11. refactor LottoController 서비스 로직 -> LottoGame으로 이관

    woony-kim committed May 21, 2023
    Configuration menu
    Copy the full SHA
    48a3567 View commit details
    Browse the repository at this point in the history

  12. refactor WinningPrizeMatcher & WinningPrizes merge

    woony-kim committed May 21, 2023
    Configuration menu
    Copy the full SHA
    e53e5d7 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2023

  1. Merge branch 'woonys' into step4

    @woonys
    woonys authored May 22, 2023
    Configuration menu
    Copy the full SHA
    ec74b6f View commit details
    Browse the repository at this point in the history

Commits on May 26, 2023

  1. refactor LottoResults 일급 컬렉션 적용

    woony-kim committed May 26, 2023
    Configuration menu
    Copy the full SHA
    3a14dff View commit details
    Browse the repository at this point in the history

  2. refactor GameCount 필드 final 할당

    woony-kim committed May 26, 2023
    Configuration menu
    Copy the full SHA
    91ce768 View commit details
    Browse the repository at this point in the history

  3. refactor LottoController -> LottoService, LottoMain -> LottoControlle… 

    …r 이름 변경
    woony-kim committed May 26, 2023
    Configuration menu
    Copy the full SHA
    469ca40 View commit details
    Browse the repository at this point in the history