Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: Add dark color scheme for text selection #829

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

sghuang19
Copy link
Member

PR Checklist

  • The changes have been tested (for bug fixes / features).
  • Docs in NexT website have been added / updated (for features).

PR Type

  • Bugfix.
  • Feature.
  • Improvement.
  • Code style update (e.g. formatting, linting).
  • Refactoring (no changes to functionality and APIs).
  • Documentation.
  • Translation.
  • Other... Please describe:

What is the current behavior?

Text selection is unreadable in dark mode.

What is the new behavior?

image

How to use?

In NexT _config.yml:

@sghuang19
Copy link
Member Author

This PR solves #770

@sghuang19 sghuang19 linked an issue Aug 15, 2024 that may be closed by this pull request
3 tasks
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10399386940

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.446%

Totals Coverage Status
Change from base Build 9517060757: 0.0%
Covered Lines: 400
Relevant Lines: 405

💛 - Coveralls

@sghuang19 sghuang19 modified the milestone: 8.20.1 Aug 20, 2024
@sghuang19
Copy link
Member Author

Should this be part of v8.20.1 or go straight to v8.21?

@stevenjoezhang stevenjoezhang added this to the 8.20.1 milestone Sep 3, 2024
@stevenjoezhang stevenjoezhang merged commit a9c940e into next-theme:master Sep 20, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong background color for selected text
3 participants