New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SCRIPT1028 caused by async #852

Merged

stevenjoezhang merged 1 commit into next-theme:master from wherewhere:fix-edge

Dec 23, 2024

Contributor

wherewhere commented Nov 30, 2024

PR Checklist

The changes have been tested (for bug fixes / features).
Docs in NexT website have been added / updated (for features).

PR Type

What is the current behavior?

Issue resolved:

On Edge HTML writting like

const { async = false } = {}

will cause Expected identifier, string or number.

And it cannot be fixed by babel.

So just change it to

const async = a.async ?? false;

and it works fine.


          Fix SCRIPT1028 caused by async

daa3db5

welcome bot commented Nov 30, 2024

Thanks so much for opening your first PR here!

CLAassistant commented Nov 30, 2024 •

edited

Loading

All committers have signed the CLA.

stevenjoezhang added the 🐞 Bug Fix label

stevenjoezhang added this to the 8.22.0 milestone

coveralls commented Nov 30, 2024

Pull Request Test Coverage Report for Build 12095435002

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 97.451%

Totals
Change from base Build 12056039421:	0.0%
Covered Lines:	400
Relevant Lines:	405

💛 - Coveralls

stevenjoezhang merged commit da4712e into next-theme:master

13 checks passed

welcome bot commented Dec 23, 2024

Congrats on merging your first pull request here! 🎉 How awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels