Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ensure the dialog name can be wrapped if needed #1074

Merged
merged 1 commit into from
Oct 17, 2023
Merged

fix: Ensure the dialog name can be wrapped if needed #1074

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/components/DialogBase.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,10 +207,12 @@ const modalProps = computed(() => ({
&__name {
// Same as the NcAppSettingsDialog
text-align: center;
height: var(--default-clickable-area);
// Should be the same height as the close button (but allow the heading to wrap in case of overflow)
min-height: var(--default-clickable-area);
line-height: var(--default-clickable-area);
margin-block: 4px 12px; // start = 4px to align with close button
// Make sure the close button does not overflow the title
margin-inline-end: calc(var(--default-clickable-area) + 4px);
}

&__content {
Expand Down
Loading