feat(FileAction): Allow to set destructive flag
#1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes the action be shown more prominently marked as destructive. Required for nextcloud/server#46732 Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Pytal
approved these changes
Sep 11, 2024
Bundle ReportChanges will increase total bundle size by 2.55kB (1.08%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
skjnldsv
reviewed
Sep 11, 2024
| @@ -12,7 +12,7 @@ export enum DefaultType { | |||
| HIDDEN = 'hidden', | |||
| } | |||
|
|
|||
| interface FileActionData { | |||
| export interface FileActionData { | |||
There was a problem hiding this comment.
Ah, I missed this.
wasn't it a leftover from your other proposal @susnux ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the action be shown more prominently marked as destructive. Required for nextcloud/server#46732