[next] feat(NcDateTimePicker): migrate to vue 3 #4631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raimund-schluessler
added
feature: datepicker
raimund-schluessler
force-pushed
the
chore/2154/pickers
branch
from
9cc977c
to
46520a8
Compare
Signed-off-by: Raimund Schlüßler <[email protected]>
raimund-schluessler
force-pushed
the
chore/2154/pickers
branch
from
46520a8
to
0987907
Compare
raimund-schluessler
requested review from
susnux,
skjnldsv,
Pytal,
ShGKme and
ChristophWurst
raimund-schluessler
changed the title
ChristophWurst
approved these changes
Oct 10, 2023
|
Anyone up for a second review? Then I could finally migrate the |
susnux
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates
NcDateTimePickerto vue 3 and also brings backNcTimezonePicker.I had to move the scoping with
ScopeComponentand the import of the datepickerscssfile into the component, because styleguide would not properly import the style. In fact, it looks like the styleguide never compiles thesrc/components/NcDateTimePicker/index.jsfile, hence, never imports and scopes the component. Moving it intoNcDateTimePicker.vueworks fine, though. And it seems to be the cleaner solution to me anyway, instead of importing styles in a merely related file.