-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NcSelect): Allow to filter users by email notation #4653
Conversation
ce93f06
to
fcf5aeb
Compare
@raimund-schluessler Ah yes there was an issue if there is no vokoscreenNG-2023-10-15_23-34-50.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works now as expected (in the docs).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to have the matching chars bolded like when typing an email without angle brackets?
Yes but need to adjust |
fcf5aeb
to
f28493b
Compare
@Pytal done vokoscreenNG-2023-10-17_12-31-29.mp4 |
Allows to filter by the email notation like `Jane <[email protected]>` Signed-off-by: Ferdinand Thiessen <[email protected]>
f28493b
to
a50aa5f
Compare
While this works, I feel like this duplicates the regex/match part. Couldn't we just set So, when typing |
Yes but when typing |
Ah, yes, I see. Valid point. |
…il notation Like `J. Doe <[email protected]>` Signed-off-by: Ferdinand Thiessen <[email protected]>
a50aa5f
to
468fbed
Compare
@Pytal Any chance to get this backported to v7? |
☑️ Resolves
Allows to filter by the email notation like
Jane <[email protected]>
🏁 Checklist