fix(NcActions): do not pass popoverBaseClass as an attr to NcPopover #4673
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Currently for some reason all props of
NcActions
are passed twice toNcPopover
: as props and as attrsnextcloud-vue/src/components/NcActions/NcActions.vue
Lines 1080 to 1105 in d939939
But
popoverBaseClass
is not aNcPopover
prop butNcActions
own prop. It should not be passed as an attribute. It results with an invalidpopoverbaseclass
attribute on an HTML element.🖼️ Screenshots
No visual changes
🏁 Checklist