Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[next] fix(docs): bring back NcAppSidebar in docs #5167

Merged
merged 1 commit into from
Jan 30, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions src/components/NcContent/NcContent.vue
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ It also will set the skip content buttons needed for accessibility.

```vue
<template>
<div id="skip-actions" />
<NcContent app-name="forms">
<NcAppNavigation>
<template #list>
Expand All @@ -49,9 +50,9 @@ It also will set the skip content buttons needed for accessibility.
<h2>Your main app content here</h2>
<NcButton @click="opened = !opened">Toggle sidebar</NcButton>
</NcAppContent>
<!-- Todo: Bring back once migrated
<NcAppSidebar v-if="opened" name="cat-picture.jpg" @close="opened=false"></NcAppSidebar>
-->
<NcAppSidebar v-if="opened" name="cat-picture.jpg" @close="opened=false">
Sidebar content
</NcAppSidebar>
</NcContent>
</template>
<script>
Expand All @@ -68,6 +69,13 @@ It also will set the skip content buttons needed for accessibility.
}
}
</script>
<style>
#content-vue {
position: relative;
width: 800px;
height: 400px;
}
</style>
```

</docs>
Expand Down Expand Up @@ -100,7 +108,6 @@ It also will set the skip content buttons needed for accessibility.
:svg="currentImage"
size="auto" />
</div>
&nbsp;<!-- TODO: Remove with vue3! This is a bug of vue-simple-portal that does not allow a single child, ref LinusBorg/vue-simple-portal#20 -->
</Teleport>
<slot />
</div>
Expand Down
Loading