[next] fix(NcAppNavigationCaption): properly align with NcAppNavigationItem #5805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot[bot]](https://avatars.githubusercontent.com/in/60201?s=60&v=4){kind=small}
backportbot
bot
requested review from
ChristophWurst,
marcoambrosini and
GVodyanov
backportbot
bot
added
bug
ShGKme
changed the title
ShGKme
approved these changes
Jul 15, 2024
|
DCO failure is relevant, SSO has different name. I wonder why CI was green in the original PR... |
GVodyanov
approved these changes
Jul 16, 2024
susnux
force-pushed
the
backport/5804/next
branch
from
49b360f
to
9d4ef4e
Compare
marcoambrosini
approved these changes
Aug 2, 2024
|
@GVodyanov Could you fix the DCO, please? Otherwise we (or better, I) cannot merge. Or someone else with more power merges 😉 |
…nItem Signed-off-by: Grigory Vodyanov <[email protected]>
GVodyanov
force-pushed
the
backport/5804/next
branch
from
9d4ef4e
to
2cdf813
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #5804