-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ExApp routes (public/user/admin) support #327
Conversation
This reverts commit ca4c14c. We need this to keep the #327 included in NC 27. We'll drop it's support after AppAPI 3.0.0. --------- Signed-off-by: Andrey Borysenko <[email protected]>
1b4d4e4
to
e7b6c9c
Compare
Logs are full of errors:
which is preventing to see clear why the DeployTests are failing when they should not... |
70d8892
to
70bc3f3
Compare
Signed-off-by: Andrey Borysenko <[email protected]>
Signed-off-by: Andrey Borysenko <[email protected]>
Signed-off-by: Andrey Borysenko <[email protected]>
Signed-off-by: Andrey Borysenko <[email protected]>
Signed-off-by: Andrey Borysenko <[email protected]>
Signed-off-by: Andrey Borysenko <[email protected]>
Signed-off-by: Andrey Borysenko <[email protected]>
Signed-off-by: Andrey Borysenko <[email protected]>
Signed-off-by: Andrey Borysenko <[email protected]>
Signed-off-by: Andrey Borysenko <[email protected]>
70bc3f3
to
3bcc649
Compare
Signed-off-by: Andrey Borysenko <[email protected]>
Signed-off-by: Andrey Borysenko <[email protected]>
Signed-off-by: Andrey Borysenko <[email protected]>
Signed-off-by: Andrey Borysenko <[email protected]>
Signed-off-by: Andrey Borysenko <[email protected]>
Signed-off-by: Andrey Borysenko <[email protected]>
Signed-off-by: Andrey Borysenko <[email protected]>
what happens when ExApp get update - in which place |
Before update the ExApp is being disabled, which should unregister the routes, after install of new ExApp container and enable procedure - the new ExApp routes then should be registered. This won'twork if it's already disabled though.. |
does this will work even if ExApp defines |
It must be registered via API, there is no |
there is, you implemented it.
|
Signed-off-by: Andrey Borysenko <[email protected]>
Signed-off-by: Andrey Borysenko <[email protected]>
Signed-off-by: Andrey Borysenko <[email protected]>
Signed-off-by: Andrey Borysenko <[email protected]>
…tion Signed-off-by: Andrey Borysenko <[email protected]>
Signed-off-by: Andrey Borysenko <[email protected]>
Signed-off-by: Andrey Borysenko <[email protected]>
Signed-off-by: Andrey Borysenko <[email protected]>
Signed-off-by: Andrey Borysenko <[email protected]>
Signed-off-by: Andrey Borysenko <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested a little, looks very great
This PR introduces new (mandatory if you use the ExApp proxy) registration of the routes that are allowed to call on ExApp via AppAPI ExApp proxy.
In your ExApp
info.xml
-external-app
add theroutes
declaration, e.g.:allows all routes, or more specific: