Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TaskProcessingAPI - unregister provider endpoint #370

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

bigcat88
Copy link
Member

@bigcat88 bigcat88 commented Aug 23, 2024

Found this when writing a small test for nc_py_api

without this change $taskProcessingProvider->id are always null

$taskProcessingProvider = $this->getExAppTaskProcessingProvider($appId, $name);
if ($taskProcessingProvider !== null) {
	$this->mapper->delete($taskProcessingProvider);
	$this->resetCacheEnabled();
	return $taskProcessingProvider;
}

@bigcat88 bigcat88 merged commit ef35b71 into main Aug 23, 2024
29 checks passed
@bigcat88 bigcat88 deleted the fix/taskprocessingapi-unregister branch August 23, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant