Move calendar sharing and settings to a modal

[st3iny]

Fix #4124
Fix #4711

WIP

First iteration

Calendar list item	Modal

Second iteration

There is no three dot menu anymore in the calendar list. There will be a single pencil icon/button which opens the modal.

[codecov]

Codecov Report

Base: 41.55% // Head: 41.30% // Decreases project coverage by -0.24% ⚠️

Coverage data is based on head (8513a72) compared to base (3b6fca7).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head 8513a72 differs from pull request most recent head e7c4897. Consider uploading reports for the commit e7c4897 to get more accurate results

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #4515      +/-   ##
============================================
- Coverage     41.55%   41.30%   -0.25%     
  Complexity      339      339              
============================================
  Files           225      226       +1     
  Lines          5641     5675      +34     
  Branches        738      743       +5     
============================================
  Hits           2344     2344              
- Misses         3297     3331      +34     

Flag	Coverage Δ
javascript	31.16% <0.00%> (-0.26%)	⬇️
php	68.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ts/AppNavigation/CalendarList/CalendarListItem.vue	0.00% <0.00%> (ø)
src/components/AppNavigation/EditCalendarModal.vue	0.00% <0.00%> (ø)
...ppNavigation/EditCalendarModal/PublishCalendar.vue	0.00% <0.00%> (ø)
...ents/AppNavigation/EditCalendarModal/ShareItem.vue	0.00% <0.00%> (ø)
.../AppNavigation/EditCalendarModal/SharingSearch.vue	0.00% <ø> (ø)
src/store/calendars.js	0.00% <0.00%> (ø)
src/views/Calendar.vue	0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[ChristophWurst]

Are the broken avatars spreading? 🙈 I thought only attendees look broken, not sharees.

[st3iny]

Are the broken avatars spreading? see_no_evil I thought only attendees look broken, not sharees.

I fixed it.

[jancborchardt]

I assume it is because still WIP, but will the rest of the dropdown also be moved into the modal? :) Basically clicking the 3 dot icon should open the modal, and all info of the dropdown should be in the modal.

What seems most fitting is if we put "Calendar details & sharing" into a modal together, so name, color, and sharing can be edited in one place. Export and Delete calendar can be done there as well, basically just like the "Conversation settings" in Talk.

[st3iny]

I assume it is because still WIP, but will the rest of the dropdown also be moved into the modal? :) Basically clicking the 3 dot icon should open the modal, and all info of the dropdown should be in the modal.

What seems most fitting is if we put "Calendar details & sharing" into a modal together, so name, color, and sharing can be edited in one place. Export and Delete calendar can be done there as well, basically just like the "Conversation settings" in Talk.

I kept them in a list for quick access. A unified design makes more sense. I'll move all other buttons to the modal too.

[ChristophWurst]

I assume it is because still WIP, but will the rest of the dropdown also be moved into the modal? :) Basically clicking the 3 dot icon should open the modal, and all info of the dropdown should be in the modal.

Could you please spec how this should look?

I liked the first iteration a lot better.

EDIT: Updated screenshot with updated button styling (which I just pushed).

[ChristophWurst]

Looks super nice now @st3iny!

Should we move the Delete button to the bottom though? In other menus we also always put it last.

[ChristophWurst]

@GretaD could you please move the buttons to the bottom of the modal?

[GretaD]

[ChristophWurst]

😎