Introduce year grid view (with FC multiMonthYear plugin) #5248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcitworld
requested review from
ChristophWurst,
jean-gui,
st3iny,
raimund-schluessler,
JuliaKirschenheuter and
miaulalala
tcitworld
changed the title
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #5248 +/- ##
=============================================
+ Coverage 22.78% 65.50% +42.72%
Complexity 371 371
=============================================
Files 237 36 -201
Lines 11636 1986 -9650
Branches 2255 0 -2255
=============================================
- Hits 2651 1301 -1350
+ Misses 8985 685 -8300
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ChristophWurst
approved these changes
May 22, 2023
| @@ -64,7 +65,7 @@ import { | |||
| modifyDate, | |||
| } from '../../../utils/date.js' | |||
| import { mapState } from 'vuex' | |||
| import formatDateRage from '../../../filters/dateRangeFormat.js' | |||
There was a problem hiding this comment.
ngl working with dates sometimes ends in rage
Closed
miaulalala
approved these changes
Jun 27, 2023
|
needs a rebase, but other than that
|
tcitworld
force-pushed
the
feat-year-view
branch
from
57413d2
to
2e85c3b
Compare
|
rebased |
|
Sorry, can you rebase once more? Static Analysis hasn't run because of timing. |
Closes #159 Signed-off-by: Thomas Citharel <[email protected]>
miaulalala
force-pushed
the
feat-year-view
branch
from
2e85c3b
to
e4ab210
Compare
|
Awesome! Cannot wait to see this. Whenever possible let us know which version it appears in (nominally 4.5.0 of the Calendar app). Job well done! Been waiting on this for years. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #159
Note: Shortcut for ListView is changed from 4 to 5 for consistency.
It could use a little style enhancement.
FullCalendar provides two "year" views: this one (multiMonthYear) and another one (dayGridYear). This one seems more suitable.