Revert "Revert "Create Talk rooms for appointments""

[ChristophWurst]

Reverts #5306 and brings back #4025

• DCO
• Rename migration
• Revert fix(appointments): Ignore extraneous columns in AppointmentConfigMapper::findByToken #5312

How to test

1. Install and enable Calendar and Talk
2. Create an appointment config in calendar, tick the Create talk room checkbox
3. Open the booking URL in a private tab
4. Book and confirm an appointment
5. Open Talk as the organizer
6. See the Talk conversation created for the event

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: +0.16% 🎉

Comparison is base (7f39c7b) 22.66% compared to head (9ca3afc) 22.82%.
Report is 15 commits behind head on main.

❗ Current head 9ca3afc differs from pull request most recent head 8838fba. Consider uploading reports for the commit 8838fba to get more accurate results

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #5319      +/-   ##
============================================
+ Coverage     22.66%   22.82%   +0.16%     
- Complexity      372      387      +15     
============================================
  Files           237      239       +2     
  Lines         11725    11745      +20     
  Branches       2282     2274       -8     
============================================
+ Hits           2657     2681      +24     
+ Misses         9068     9064       -4     

Flag	Coverage Δ
javascript	13.93% <0.00%> (+0.03%)	⬆️
php	64.94% <ø> (-0.54%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
src/components/AppointmentConfigModal.vue	0.00% <0.00%> (ø)
...s/AppointmentConfigModal/CheckedDurationSelect.vue	0.00% <ø> (ø)
...rc/components/AppointmentConfigModal/TextInput.vue	0.00% <0.00%> (ø)
src/models/appointmentConfig.js	0.00% <0.00%> (ø)
src/store/settings.js	87.71% <0.00%> (-0.88%)	⬇️

... and 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[hamza221]

2 talk rooms are created but it's a problem with the original Pr I'm guessing. I can try to solve it when this is merged.
Also The booking page needs a loading animation, I'll create an issue
But aside from this works perfectly 👍

[ChristophWurst]

Did you book two appointments? The room will not be shared. If person a and person b book, they get two separate rooms. If person a books two slots, there will still be two rooms.

[hamza221]

No just one appointment with one user

[hamza221]

Looks deterministic

[ChristophWurst]

I'll test another time. This doesn't seem right

[hamza221]

The user receives only one confirmation email, with the first room's link .

[st3iny]

The AppointmentBookedEvent is emitted twice in \OCA\Calendar\Service\Appointments\BookingService::confirmBooking which leads to two rooms being created.