Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Set up static analysis #5344

Merged
merged 1 commit into from
Jun 29, 2023
Merged

chore: Set up static analysis #5344

merged 1 commit into from
Jun 29, 2023

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Jun 28, 2023

Closes #3765

For code QA. There are existing issues Psalm could locate. Most were fixable. The four remaining ones were added to the baseline.

Todo

  • Green CI
  • Make static analysis summary a mandatory check

@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.41 🎉

Comparison is base (79b3bbf) 22.36% compared to head (c58d5c1) 22.78%.

❗ Current head c58d5c1 differs from pull request most recent head 49e6bd2. Consider uploading reports for the commit 49e6bd2 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5344      +/-   ##
============================================
+ Coverage     22.36%   22.78%   +0.41%     
- Complexity      359      371      +12     
============================================
  Files           236      237       +1     
  Lines         11554    11636      +82     
  Branches       2250     2255       +5     
============================================
+ Hits           2584     2651      +67     
- Misses         8970     8985      +15     
Flag Coverage Δ
javascript 13.98% <ø> (-0.02%) ⬇️
php 65.50% <ø> (+1.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 28, 2023
@ChristophWurst ChristophWurst marked this pull request as ready for review June 28, 2023 20:34
Signed-off-by: Christoph Wurst <[email protected]>
@ChristophWurst ChristophWurst merged commit 913aad7 into main Jun 29, 2023
34 of 35 checks passed
@ChristophWurst ChristophWurst deleted the chore/static-analysis branch June 29, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup static analysis tools
2 participants