Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(duplicateEvent): Open duplicate in sidebar not original #5348

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

JohannesGGE
Copy link
Contributor

Fix: #4598

How to test:

  1. Create an event
  2. Open the event again in simplified editor
  3. Duplicate event
  4. Click "More" to show sidebar editor
  5. Change something
  6. Save Event

On main this leads to updating the original event.
In this PR a new event is created (with the copied and edited data)

@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.41 🎉

Comparison is base (79b3bbf) 22.36% compared to head (3dfd7fa) 22.78%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5348      +/-   ##
============================================
+ Coverage     22.36%   22.78%   +0.41%     
- Complexity      359      371      +12     
============================================
  Files           236      237       +1     
  Lines         11554    11636      +82     
  Branches       2250     2255       +5     
============================================
+ Hits           2584     2651      +67     
- Misses         8970     8985      +15     
Flag Coverage Δ
javascript 13.98% <0.00%> (-0.02%) ⬇️
php 65.50% <ø> (+1.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nents/Editor/Properties/PropertySelectMultiple.vue 0.00% <0.00%> (ø)
...Properties/PropertySelectMultipleColoredOption.vue 0.00% <0.00%> (ø)
src/mixins/EditorMixin.js 3.61% <0.00%> (-0.05%) ⬇️
src/views/EditSidebar.vue 0.00% <0.00%> (ø)
src/views/EditSimple.vue 0.00% <ø> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@hamza221 hamza221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

@JohannesGGE JohannesGGE merged commit 723c58b into main Jun 30, 2023
33 of 34 checks passed
@JohannesGGE JohannesGGE deleted the fix/4598/open-sidebar-duplicate branch June 30, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sidebar editor updates original even instead of duplicate
2 participants