Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(categories): fall back to empty array #5382

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Jul 28, 2023

Followup to #5161

The categories are not injected on some views, e.g. the public view.

Repro

  1. Create a calendar and share it publicly via a link.
  2. Open the calendar in a private/anonymous tab.
  3. Observe how shit breaks because the initial state for categories is missing and no fallback is specified.

The categories are not injected on some views, e.g. the public view.

Signed-off-by: Richard Steinmetz <[email protected]>
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (9f53311) 22.71% compared to head (32fa3fa) 22.71%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5382   +/-   ##
=========================================
  Coverage     22.71%   22.71%           
  Complexity      372      372           
=========================================
  Files           237      237           
  Lines         11679    11679           
  Branches       2270     2270           
=========================================
  Hits           2653     2653           
  Misses         9026     9026           
Flag Coverage Δ
javascript 13.94% <0.00%> (ø)
php 65.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/mixins/EditorMixin.js 3.61% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review labels Jul 28, 2023
@st3iny st3iny merged commit 9ac83f1 into main Jul 28, 2023
39 of 40 checks passed
@st3iny st3iny deleted the fix/categories/system-tags-on-public-view branch July 28, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug Feature: Public sharing
Projects
Development

Successfully merging this pull request may close these issues.

2 participants