Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix navigation button positioning #5390

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Fix navigation button positioning #5390

merged 1 commit into from
Aug 3, 2023

Conversation

jancborchardt
Copy link
Member

To illustrate the issues, the view switcher on the right is in hovered state:

  • More whitespace to the top of the navigation than to the left
  • Using hardcoded values instead of variables
  • "Event" and "Today" vertically not aligned with view switcher
Before After
image image

Signed-off-by: Jan C. Borchardt <[email protected]>
@jancborchardt jancborchardt added 3. to review Waiting for reviews bug design Related to design, interface, interaction design, UX, etc. labels Aug 2, 2023
@jancborchardt jancborchardt self-assigned this Aug 2, 2023
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Patch coverage: 50.00% and no project coverage change.

Comparison is base (814980e) 22.74% compared to head (12f5abd) 22.74%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5390   +/-   ##
=========================================
  Coverage     22.74%   22.74%           
  Complexity      372      372           
=========================================
  Files           237      237           
  Lines         11684    11684           
  Branches       2270     2270           
=========================================
  Hits           2657     2657           
  Misses         9027     9027           
Flag Coverage Δ
javascript 13.95% <50.00%> (ø)
php 65.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/views/Calendar.vue 0.00% <ø> (ø)
src/views/EditSidebar.vue 0.00% <0.00%> (ø)
src/store/settings.js 88.59% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@st3iny
Copy link
Member

st3iny commented Aug 3, 2023

@jancborchardt Thanks for the PR 🙏 I can't spot differences between the two screenshots. Could it be that you accidentally uploaded the same picture twice?

EDIT: Now I see it.

@tcitworld
Copy link
Member

I only notice the second row of button being a little closer to the first row.

@st3iny
Copy link
Member

st3iny commented Aug 3, 2023

Ahh, now I see it. The whitespace around the navigation button also changed a tiny bit to make it more even.

Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works.

@st3iny st3iny added this to the v4.5.0 milestone Aug 3, 2023
@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 3, 2023
@st3iny
Copy link
Member

st3iny commented Aug 3, 2023

/backport to stable4.4

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request A backport was requested for this pull request label Aug 3, 2023
@st3iny st3iny merged commit a32bf5d into main Aug 3, 2023
40 checks passed
@st3iny st3iny deleted the fix/navigation-buttons branch August 3, 2023 09:24
@backportbot-nextcloud backportbot-nextcloud bot removed the backport-request A backport was requested for this pull request label Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug design Related to design, interface, interaction design, UX, etc.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants