-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix navigation button positioning #5390
Conversation
Signed-off-by: Jan C. Borchardt <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #5390 +/- ##
=========================================
Coverage 22.74% 22.74%
Complexity 372 372
=========================================
Files 237 237
Lines 11684 11684
Branches 2270 2270
=========================================
Hits 2657 2657
Misses 9027 9027
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
@jancborchardt Thanks for the PR 🙏 EDIT: Now I see it. |
I only notice the second row of button being a little closer to the first row. |
Ahh, now I see it. The whitespace around the navigation button also changed a tiny bit to make it more even. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works.
/backport to stable4.4 |
To illustrate the issues, the view switcher on the right is in hovered state: