fix(appointments): Rate limit config creation and booking #5680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable4.6 |
backportbot-nextcloud
bot
added
the
backport-request
|
/backport to stable3.5 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5680 +/- ##
============================================
- Coverage 24.44% 24.42% -0.03%
Complexity 418 418
============================================
Files 243 243
Lines 10859 10870 +11
Branches 1780 1787 +7
============================================
Hits 2655 2655
- Misses 8204 8215 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
st3iny
approved these changes
Jan 10, 2024
|
Psalm fails |
Abusing the appointment config endpoint can lead to additional server load. Sending bulks of booking requests can lead to mass notifications and emails and server load, too. Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
force-pushed
the
fix/appointments/rate-limit-config-creation
branch
from
af1f17f
to
0f77b41
Compare
ChristophWurst
added
4. to release
ChristophWurst
deleted the
fix/appointments/rate-limit-config-creation
branch
|
The backport to stable3.5 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable3.5
git pull origin stable3.5
# Create the new backport branch
git checkout -b fix/foo-stable3.5
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable3.5Error: Unknown error More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limits the number of bookings a single user can do.