Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/category selector fixes #5781

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Fix/category selector fixes #5781

merged 2 commits into from
Feb 21, 2024

Conversation

GVodyanov
Copy link
Contributor

Fix #5780

@GVodyanov GVodyanov self-assigned this Feb 20, 2024
@GVodyanov GVodyanov added 3. to review Waiting for reviews bug design Related to design, interface, interaction design, UX, etc. labels Feb 20, 2024
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3369fc8) 24.19% compared to head (82c1ae6) 24.19%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5781   +/-   ##
=========================================
  Coverage     24.19%   24.19%           
  Complexity      423      423           
=========================================
  Files           243      243           
  Lines         11005    11005           
  Branches       1825     1825           
=========================================
  Hits           2663     2663           
  Misses         8342     8342           
Flag Coverage Δ
javascript 15.11% <ø> (ø)
php 61.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works. Thank you very much for fixing this :)

Comment on lines +889 to +894
.vs__dropdown-option span {
overflow: hidden;
text-overflow: ellipsis;
white-space: nowrap;
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That works quite well. I don't like that it isn't scoped but I don't see any other way as the popover is inserted directly below the body.

@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 21, 2024
@st3iny st3iny merged commit 2056656 into main Feb 21, 2024
40 checks passed
@st3iny st3iny deleted the Fix/category-selector-fixes branch February 21, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug design Related to design, interface, interaction design, UX, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit sidebar: Category picker not expanding with more selected elements
2 participants