feat: add a setting for the default calendar url #5790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5790 +/- ##
============================================
- Coverage 24.19% 24.13% -0.07%
Complexity 423 423
============================================
Files 243 243
Lines 11005 11038 +33
Branches 1824 1833 +9
============================================
+ Hits 2663 2664 +1
- Misses 8342 8374 +32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
st3iny
force-pushed
the
feat/default-calendar
branch
from
8b83768
to
ba8125f
Compare
st3iny
added
3. to review
This was referenced Feb 28, 2024
st3iny
force-pushed
the
feat/default-calendar
branch
from
ba8125f
to
3bfa8c8
Compare
st3iny
commented
Feb 28, 2024
st3iny
force-pushed
the
feat/default-calendar
branch
from
3bfa8c8
to
c130fad
Compare
tcitworld
reviewed
Feb 28, 2024
There was a problem hiding this comment.
Since it requires nextcloud/server#43745, shouldn't this only be showed on NC 29+ ?
|
Good catch! I'll add a version check. |
hamza221
approved these changes
Feb 29, 2024
ChristophWurst
force-pushed
the
feat/default-calendar
branch
from
29686c0
to
70695f9
Compare
Co-authored-by: Lukas Boersma <[email protected]> Co-authored-by: szaimen <[email protected]> Signed-off-by: Richard Steinmetz <[email protected]>
st3iny
force-pushed
the
feat/default-calendar
branch
from
70695f9
to
7a307bb
Compare
st3iny
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1835
Based on #2331 and #4310
Closes #2331
Closes #4310
Requires:
TODO