Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: added between calendars patterns on events #5801

Closed
wants to merge 24 commits into from
Closed

Feature: added between calendars patterns on events #5801

wants to merge 24 commits into from

Conversation

arublov
Copy link
Member

@arublov arublov commented Feb 27, 2024 •
edited
Loading

@arublov arublov self-assigned this Feb 27, 2024
@arublov arublov added the 2. developing Work in progress label Feb 27, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.97%. Comparing base (fd46192) to head (234018a).
Report is 37 commits behind head on main.

❗ Current head 234018a differs from pull request most recent head a32bafb. Consider uploading reports for the commit a32bafb to get more accurate results

Additional details and impacted files 
@@              Coverage Diff              @@
##               main    #5801       +/-   ##
=============================================
+ Coverage     24.19%   61.97%   +37.78%     
  Complexity      423      423               
=============================================
  Files           243       39      -204     
  Lines         11005     2133     -8872     
  Branches       1825        0     -1825     
=============================================
- Hits           2663     1322     -1341     
+ Misses         8342      811     -7531
Flag Coverage Δ
javascript ?
php 61.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nextcloud-bot and others added 23 commits March 1, 2024 11:15
@nextcloud-bot @arublov
Fix(l10n): Update translations from Transifex
3b694f2 
Signed-off-by: Nextcloud bot <[email protected]>
@renovate @arublov
chore(deps): bump vimeo/psalm from 5.22.1 to ^5.22.2 (main) (#5802)
430b576 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @arublov
fix(deps): bump @nextcloud/dialogs from 4.2.5 to ^4.2.6 (main) (#5803)
9859346 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @arublov
chore(deps): bump andstor/file-existence-action digest to 20b4d2e
06f0f8d 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @arublov
chore(deps): bump shivammathur/setup-php digest to a870b0a
6d0a2e0 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @arublov
chore(deps): bump svenstaro/upload-release-action digest to 04733e0
6e19890 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @arublov
chore(deps): bump dorny/paths-filter action from v3.0.0 to v3.0.1 (ma…
8ae658e 
…in) (#5808)

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @ChristophWurst @arublov
chore(deps): bump nextcloud/coding-standard from 1.1.1 to ^1.2.1 (mai…
9ca7500 
…n) (#5741)

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Christoph Wurst <[email protected]>
Co-authored-by: Christoph Wurst <[email protected]>
@renovate @arublov
chore(deps): bump actions/setup-node digest to 1a4442c
783f7b7 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @arublov
chore(deps): bump @nextcloud/eslint-config from 8.2.1 to ^8.3.0 (main) (
a6d4ec8 
#5810)

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @arublov
fix(deps): bump core-js from 3.35.1 to ^3.36.0 (main) (#5811)
8338c6a 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @arublov
fix(deps): bump webdav from 5.3.2 to ^5.4.0 (main) (#5812)
21a9585 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @arublov
fix(deps): bump @nextcloud/vue from 8.7.0 to ^8.7.1
b3b723b 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @arublov
chore(deps): bump @nextcloud/browserslist-config from 2.3.0 to v3
8929693 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@st3iny @arublov
chore: remove obsolete server version check
964ae98 
Signed-off-by: Richard Steinmetz <[email protected]>
@miaulalala @arublov
fix: update holiday calendars
13a9bac 
Signed-off-by: Anna Larch <[email protected]>
@nextcloud-bot @arublov
Fix(l10n): Update translations from Transifex
a8190f6 
Signed-off-by: Nextcloud bot <[email protected]>
@LukasBoersma @szaimen @arublov
feat: add a setting for the default calendar url
a6b354a 
Co-authored-by: Lukas Boersma <[email protected]>
Co-authored-by: szaimen <[email protected]>
Signed-off-by: Richard Steinmetz <[email protected]>
@st3iny @arublov
chore(deps): bump @nextcloud/cdav-library to ^1.3.0
b555bc7 
Signed-off-by: Richard Steinmetz <[email protected]>
@hamza221 @arublov
Improve free/busy UI
e0f5ef4 
Signed-off-by: hamza mahjoubi <[email protected]>
@miaulalala @arublov
fix: kazakhstan holiday calendars
1c68d64 
Signed-off-by: Anna Larch <[email protected]>
@renovate @arublov
chore(deps): bump babel monorepo from 7.23.9 to ^7.24.0 (main) (#5822)
b5db24d 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@nextcloud-bot @arublov
Fix(l10n): Update translations from Transifex
a32bafb 
Signed-off-by: Nextcloud bot <[email protected]>
@arublov arublov closed this Mar 1, 2024
@arublov arublov deleted the feature/integration-patterns-between-calendars-for-events branch March 1, 2024 11:21
@miaulalala
Copy link
Contributor

Can I ask why you closed this PR? I think it's a good idea!

@arublov
Copy link
Member Author

arublov commented Mar 1, 2024 •
edited
Loading

@miaulalala , I'll open a new PR soon, I made a mistake with rebase, it was a draft PR.

@github-actions GitHub Actions
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SebastianKrupinski SebastianKrupinski Awaiting requested review from SebastianKrupinski SebastianKrupinski will be requested when the pull request is marked ready for review SebastianKrupinski is a code owner

@st3iny st3iny Awaiting requested review from st3iny st3iny will be requested when the pull request is marked ready for review st3iny is a code owner

@tcitworld tcitworld Awaiting requested review from tcitworld tcitworld will be requested when the pull request is marked ready for review tcitworld is a code owner

Assignees

@arublov arublov

Labels
2. developing Work in progress feedback-requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Relationship between events and calendars relies on colors
6 participants
@arublov @miaulalala @nextcloud-bot @st3iny @LukasBoersma @hamza221