Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow calendar-wide transparency settings #6169

Merged
merged 1 commit into from
Jul 23, 2024
Merged

feat: allow calendar-wide transparency settings #6169

merged 1 commit into from
Jul 23, 2024

Conversation

miaulalala
Copy link
Contributor

@miaulalala miaulalala commented Jul 15, 2024 •
edited by st3iny
Loading

Fixes #3193

Needs nextcloud/cdav-library#908
Needs nextcloud/cdav-library#909

How to test:

  • Uncheck the checkbox in the Edit Calendar Modal
  • Check oc_calendars row for the calendar - the value for the transparency should change to 1 for transparent when the checkbox is unchecked.

@miaulalala miaulalala added the 2. developing Work in progress label Jul 15, 2024
@miaulalala miaulalala added this to the v5.0.0 milestone Jul 15, 2024
@miaulalala miaulalala self-assigned this Jul 15, 2024
@miaulalala miaulalala marked this pull request as draft July 15, 2024 22:43
@miaulalala miaulalala added Feature: Scheduling Anything around scheduling meetings, free-busy, resources, attendees and so on feature: caldav labels Jul 15, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 7.69231% with 12 lines in your changes missing coverage. Please review.

Project coverage is 23.93%. Comparing base (307a265) to head (c1a408e).
Report is 6 commits behind head on main.

Files Patch % Lines
src/components/AppNavigation/EditCalendarModal.vue 0.00% 6 Missing ⚠️
src/store/calendars.js 0.00% 5 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #6169      +/-   ##
============================================
- Coverage     23.97%   23.93%   -0.04%     
  Complexity      457      457              
============================================
  Files           247      247              
  Lines         11606    11627      +21     
  Branches       2188     2195       +7     
============================================
+ Hits           2782     2783       +1     
- Misses         8508     8527      +19     
- Partials        316      317       +1
Flag Coverage Δ
javascript 15.44% <7.69%> (-0.03%) ⬇️
php 59.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@st3iny
Copy link
Member

st3iny commented Jul 16, 2024 •
edited
Loading

The cdav library was released and can be updated here: https://www.npmjs.com/package/@nextcloud/cdav-library/v/1.5.0

@miaulalala miaulalala force-pushed the feat/3193/allow-calendarwide-freebusy-settings branch from 6f570c1 to d67156b Compare July 17, 2024 12:47
@miaulalala miaulalala added the blocked This ticket or PR is blocked by another one label Jul 17, 2024
@miaulalala miaulalala mentioned this pull request Jul 18, 2024
Closed
@miaulalala miaulalala added 3. to review Waiting for reviews and removed blocked This ticket or PR is blocked by another one 2. developing Work in progress labels Jul 18, 2024
@miaulalala miaulalala requested review from st3iny and GVodyanov and removed request for st3iny July 18, 2024 14:09
@miaulalala miaulalala marked this pull request as ready for review July 18, 2024 14:09
@st3iny
Copy link
Member

st3iny commented Jul 18, 2024 •
edited
Loading

The cdav library was released again: https://www.npmjs.com/package/@nextcloud/cdav-library/v/1.5.1

It looks like it was already updated on main. So another rebase will pull in the dependency. (PS: Makes testing easier for reviewers.)

Ref #6182

@miaulalala miaulalala force-pushed the feat/3193/allow-calendarwide-freebusy-settings branch from 16595ab to 4ae8a69 Compare July 18, 2024 14:21
@hamza221
Copy link
Contributor

hamza221 commented Jul 18, 2024 •
edited
Loading

There's enough space to show the whole text, but it should be fixed upstream
image

@hamza221
Copy link
Contributor

Works otherwise ✅

@GVodyanov GVodyanov mentioned this pull request Jul 18, 2024
Merged
ChristophWurst
ChristophWurst reviewed Jul 22, 2024
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

src/components/AppNavigation/EditCalendarModal.vue Show resolved Hide resolved
src/components/AppNavigation/EditCalendarModal.vue Show resolved Hide resolved
src/models/calendar.js Outdated Show resolved Hide resolved
st3iny
st3iny requested changes Jul 22, 2024
View reviewed changes
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works otherwise

src/components/AppNavigation/EditCalendarModal.vue Outdated Show resolved Hide resolved
st3iny
st3iny approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works now. The wording is now consistent with the actual state.

@st3iny st3iny added the enhancement New feature request label Jul 23, 2024
@miaulalala
parent 7e436be
c1a408e 
author Anna Larch <[email protected]> 1721083381 +0200
committer Anna Larch <[email protected]> 1721726554 +0200

feat: allow calendar-wide transparency settings

Signed-off-by: Anna Larch <[email protected]>
@miaulalala miaulalala force-pushed the feat/3193/allow-calendarwide-freebusy-settings branch from b9d3b89 to c1a408e Compare July 23, 2024 09:24
@miaulalala miaulalala merged commit 566f8ac into main Jul 23, 2024
30 of 32 checks passed
@miaulalala miaulalala deleted the feat/3193/allow-calendarwide-freebusy-settings branch July 23, 2024 09:40
@miaulalala miaulalala mentioned this pull request Aug 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux left review comments

@ChristophWurst ChristophWurst ChristophWurst left review comments

@hamza221 hamza221 hamza221 approved these changes

@st3iny st3iny st3iny approved these changes

@GVodyanov GVodyanov Awaiting requested review from GVodyanov

@GretaD GretaD Awaiting requested review from GretaD

Assignees

@miaulalala miaulalala

Labels
3. to review Waiting for reviews enhancement New feature request feature: caldav Feature: Scheduling Anything around scheduling meetings, free-busy, resources, attendees and so on
Projects
None yet
Milestone
v5.0.0
Development

Successfully merging this pull request may close these issues.

Option to set a calendar as transparent for free/busy
6 participants
@miaulalala @st3iny @hamza221 @ChristophWurst @susnux @GVodyanov