Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings: set proper width for all NcSelects to be the same width #6198

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

GVodyanov
Copy link
Contributor

Fix #6138

A B
Screenshot from 2024-07-24 10-47-42 Screenshot from 2024-07-24 10-46-42

@GVodyanov GVodyanov added the 3. to review Waiting for reviews label Jul 24, 2024
@GVodyanov GVodyanov self-assigned this Jul 24, 2024
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 29.41%. Comparing base (0271a5b) to head (f26d8b0).
Report is 12 commits behind head on main.

Files Patch % Lines
src/components/AppNavigation/Settings.vue 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6198      +/-   ##
============================================
+ Coverage     23.93%   29.41%   +5.47%     
- Complexity      457      914     +457     
============================================
  Files           247      291      +44     
  Lines         11627    14012    +2385     
  Branches       2196     2214      +18     
============================================
+ Hits           2783     4121    +1338     
- Misses         8527     9573    +1046     
- Partials        317      318       +1     
Flag Coverage Δ
javascript 15.26% <0.00%> (-0.19%) ⬇️
php 59.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@miaulalala
Copy link
Contributor

is left the fix?

@GVodyanov
Copy link
Contributor Author

is left the fix?

Yep

@miaulalala miaulalala merged commit 5b67294 into main Jul 24, 2024
27 of 28 checks passed
@miaulalala miaulalala deleted the style/set-width-on-settings-inputs branch July 24, 2024 10:38
@miaulalala
Copy link
Contributor

Does this need a backport?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scrolling issues in app settings menu
2 participants