fix: enable attendee selection on shared calendars

[SebastianKrupinski]

enable attendee selection on shared calendars

This is needed to test shared calendar event invitation sending nextcloud/server#45054

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.70%. Comparing base (8dbff4c) to head (34de776).
Report is 1 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #6202      +/-   ##
============================================
+ Coverage     23.67%   23.70%   +0.02%     
  Complexity      457      457              
============================================
  Files           249      249              
  Lines         11774    11763      -11     
  Branches       2203     2210       +7     
============================================
  Hits           2788     2788              
+ Misses         8669     8659      -10     
+ Partials        317      316       -1     

Flag	Coverage Δ
javascript	15.27% <ø> (+0.01%)	⬆️
php	59.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[miaulalala]

NVM, wrong ics

Irrelevant

[tcitworld]

I don't know what's the plan for nextcloud/server#45054 (backports ?), but in any case, this should depend on the server version to be activated.

[miaulalala]

Popover modal is not in sync with sidebar modal:

Popover:

Popover Editor:

EditorSidebar:

[SebastianKrupinski]

@miaulalala the popup modal is NOT out of sync, it just does not have enough room to show all the attendees, it has the same behavior with a personal calendar. This has nothing to do with this PR and would need to be addresses in another PR.

[miaulalala]

@miaulalala the popup modal is NOT out of sync, it just does not have enough room to show all the attendees, it has the same behavior with a personal calendar. This has nothing to do with this PR and would need to be addresses in another PR.

fair enough, can you please open a ticket with these findings?

[ChristophWurst]

I don't know what's the plan for nextcloud/server#45054 (backports ?), but in any case, this should depend on the server version to be activated.

Calendar main is 30+ and we won't backport this to my knowledge. This should be alright :)

[ChristophWurst]

An organizer selection is still missing for the assistant use case, right? As in, Alice shares with her assistant Bob, who invites Charly. Alice is saved as organizer, bob is an attendee.

[SebastianKrupinski]

Additional thoughts...

Some front end UI changes that would be beneficial...

• Drop down on attendee tab to selected the organizer of the event. Use cases...

• Sharee is an assistant with access to the Managers calendar (Sharer)... The organizer of the event should be the Sharer.
• Sharee is a employee with access to the Company calendar (Sharer)... The organizer of the event should be the Sharee.

Some back end changes that would be beneficial...

• Additional calendar property to control access to send on behalf of the Sharer.

Draw backs...

• The above features would only work in the NC UI. CalDAV dose support the "CALDAV:schedule-send" ACL permission but I doubt that there are many if any clients that actually support this feature.

[SebastianKrupinski]

An organizer selection is still missing for the assistant use case, right? As in, Alice shares with her assistant Bob, who invites Charly. Alice is saved as organizer, bob is an attendee.

Correct. See comments above.