Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default reminder ui bug #6249

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

abdou6666
Copy link
Contributor

#6185

before :
image

after :
image

@hamza221 hamza221 added 3. to review Waiting for reviews skill:frontend Issues and PRs that require JavaScript/Vue/styling development skills bug labels Aug 9, 2024
@hamza221
Copy link
Contributor

hamza221 commented Aug 9, 2024

The text is too long, it will never be displayed fully. @ChristophWurst would only changing the default reminder be enough to close the issue ?

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 29.60%. Comparing base (8dbff4c) to head (def95a6).
Report is 48 commits behind head on main.

Files Patch % Lines
src/components/AppNavigation/Settings.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6249      +/-   ##
============================================
+ Coverage     23.67%   29.60%   +5.92%     
- Complexity      457      908     +451     
============================================
  Files           249      287      +38     
  Lines         11774    13885    +2111     
  Branches       2203     2201       -2     
============================================
+ Hits           2788     4111    +1323     
- Misses         8669     9458     +789     
+ Partials        317      316       -1     
Flag Coverage Δ
javascript 15.45% <0.00%> (+0.19%) ⬆️
php 59.53% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@miaulalala miaulalala merged commit 4e99f60 into nextcloud:main Aug 22, 2024
34 of 35 checks passed
@miaulalala
Copy link
Contributor

No backport due to translations

@miaulalala miaulalala added this to the v5.0.1 milestone Aug 22, 2024
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@st3iny st3iny modified the milestones: v5.0.1, v5.1.0 Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug feedback-requested skill:frontend Issues and PRs that require JavaScript/Vue/styling development skills
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants