Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make call token extraction more robust #6253

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Aug 12, 2024

No description provided.

@st3iny st3iny added the 3. to review Waiting for reviews label Aug 12, 2024
@st3iny st3iny self-assigned this Aug 12, 2024
@st3iny st3iny added the bug label Aug 12, 2024
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 23.71%. Comparing base (a2e3a90) to head (401f674).
Report is 3 commits behind head on main.

Files Patch % Lines
src/services/talkService.js 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6253      +/-   ##
============================================
+ Coverage     23.70%   23.71%   +0.01%     
  Complexity      457      457              
============================================
  Files           249      249              
  Lines         11763    11765       +2     
  Branches       2211     2211              
============================================
+ Hits           2788     2790       +2     
- Misses         8659     8660       +1     
+ Partials        316      315       -1     
Flag Coverage Δ
javascript 15.29% <66.66%> (+0.01%) ⬆️
php 59.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@miaulalala miaulalala merged commit 9d11bab into main Aug 12, 2024
28 checks passed
@miaulalala miaulalala deleted the fix/call-token-extraction branch August 12, 2024 10:13
@miaulalala
Copy link
Contributor

/backport to stable4.7

@backportbot backportbot bot added the backport-request A backport was requested for this pull request label Aug 12, 2024
@backportbot backportbot bot removed the backport-request A backport was requested for this pull request label Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
Status: ☑️ Done
Development

Successfully merging this pull request may close these issues.

2 participants