Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(settings): adjust design of import button #6255

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Aug 13, 2024

Before After
grafik grafik

@st3iny st3iny added 3. to review Waiting for reviews bug design Related to design, interface, interaction design, UX, etc. labels Aug 13, 2024
@st3iny st3iny added this to the v5.0.0 milestone Aug 13, 2024
@st3iny st3iny self-assigned this Aug 13, 2024
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 29.43%. Comparing base (401f674) to head (911d5b9).
Report is 3 commits behind head on main.

Files Patch % Lines
...s/AppNavigation/Settings/SettingsImportSection.vue 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6255      +/-   ##
============================================
+ Coverage     23.71%   29.43%   +5.71%     
- Complexity      457      914     +457     
============================================
  Files           249      291      +42     
  Lines         11765    14008    +2243     
  Branches       2211     2212       +1     
============================================
+ Hits           2790     4123    +1333     
- Misses         8660     9569     +909     
- Partials        315      316       +1     
Flag Coverage Δ
javascript 15.28% <0.00%> (-0.01%) ⬇️
php 59.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@st3iny st3iny merged commit 0d63e67 into main Aug 13, 2024
28 of 29 checks passed
@st3iny st3iny deleted the fix/settings/import-button-design branch August 13, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug design Related to design, interface, interaction design, UX, etc.
Projects
Status: ☑️ Done
Development

Successfully merging this pull request may close these issues.

2 participants