Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fc): adjust week day header border radius to new design #6256

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Aug 13, 2024

Follow-up to #6236

Before

grafik

After

grafik

@st3iny st3iny added bug design Related to design, interface, interaction design, UX, etc. Feature: Fullcalendar labels Aug 13, 2024
@st3iny st3iny added this to the v5.0.0 milestone Aug 13, 2024
@st3iny st3iny self-assigned this Aug 13, 2024
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.71%. Comparing base (401f674) to head (e4dd483).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #6256   +/-   ##
=========================================
  Coverage     23.71%   23.71%           
  Complexity      457      457           
=========================================
  Files           249      249           
  Lines         11765    11765           
  Branches       2211     2212    +1     
=========================================
  Hits           2790     2790           
+ Misses         8660     8659    -1     
- Partials        315      316    +1     
Flag Coverage Δ
javascript 15.29% <ø> (ø)
php 59.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧱

@st3iny st3iny enabled auto-merge August 13, 2024 08:42
@st3iny st3iny added the 4. to release Ready to be released and/or waiting for tests to finish label Aug 13, 2024
@st3iny st3iny merged commit 74411f8 into main Aug 13, 2024
30 checks passed
@st3iny st3iny deleted the fix/fc/week-day-header-border-radius branch August 13, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug design Related to design, interface, interaction design, UX, etc. Feature: Fullcalendar
Projects
Status: ☑️ Done
Development

Successfully merging this pull request may close these issues.

2 participants