Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: list hidden shared calendars correctly #6261

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

hamza221
Copy link
Contributor

@hamza221 hamza221 commented Aug 14, 2024

Fixes #6259

b a
image image

@hamza221 hamza221 added 3. to review Waiting for reviews bug skill:frontend Issues and PRs that require JavaScript/Vue/styling development skills labels Aug 14, 2024
@hamza221 hamza221 self-assigned this Aug 14, 2024
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.60%. Comparing base (d97533d) to head (151e27a).
Report is 12 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6261      +/-   ##
============================================
+ Coverage     23.89%   29.60%   +5.71%     
- Complexity      454      908     +454     
============================================
  Files           246      287      +41     
  Lines         11651    13884    +2233     
  Branches       2199     2188      -11     
============================================
+ Hits           2784     4111    +1327     
- Misses         8551     9458     +907     
+ Partials        316      315       -1     
Flag Coverage Δ
javascript 15.45% <ø> (-0.01%) ⬇️
php 59.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@miaulalala
Copy link
Contributor

/backport to stable5.0

@backportbot backportbot bot added the backport-request A backport was requested for this pull request label Aug 14, 2024
@ChristophWurst ChristophWurst merged commit e5f9def into main Aug 19, 2024
24 of 28 checks passed
@ChristophWurst ChristophWurst deleted the Fix/list-hidden-shared-calendars-correctly branch August 19, 2024 06:10
@backportbot backportbot bot removed the backport-request A backport was requested for this pull request label Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug skill:frontend Issues and PRs that require JavaScript/Vue/styling development skills
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hidden shared calendars should be listed in *Hidden*, not *Shared calendars*
4 participants