Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(attachments): improve layout #6274

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Aug 21, 2024

No description provided.

Signed-off-by: Richard Steinmetz <[email protected]>
@st3iny st3iny added the 3. to review Waiting for reviews label Aug 21, 2024
@st3iny st3iny self-assigned this Aug 21, 2024
@st3iny
Copy link
Member Author

st3iny commented Aug 21, 2024

/backport to stable4.7

@backportbot backportbot bot added the backport-request A backport was requested for this pull request label Aug 21, 2024
@st3iny st3iny added this to the v5.1.0 milestone Aug 21, 2024
@st3iny
Copy link
Member Author

st3iny commented Aug 21, 2024

/backport to stable5.0

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 23.88%. Comparing base (6483171) to head (e9e9bcf).
Report is 10 commits behind head on main.

Files Patch % Lines
.../components/Editor/Attachments/AttachmentsList.vue 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #6274   +/-   ##
=========================================
  Coverage     23.88%   23.88%           
  Complexity      454      454           
=========================================
  Files           246      246           
  Lines         11655    11655           
  Branches       2188     2188           
=========================================
  Hits           2784     2784           
  Misses         8556     8556           
  Partials        315      315           
Flag Coverage Δ
javascript 15.45% <0.00%> (ø)
php 59.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@miaulalala miaulalala modified the milestones: v5.1.0, v5.0.1 Aug 21, 2024
@ChristophWurst ChristophWurst merged commit 36a38db into main Aug 21, 2024
34 of 35 checks passed
@ChristophWurst ChristophWurst deleted the fix/attachments/improve-layout branch August 21, 2024 09:26
@backportbot backportbot bot removed the backport-request A backport was requested for this pull request label Aug 21, 2024
@st3iny st3iny modified the milestones: v5.0.1, v5.1.0 Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants