Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow inviting contact groups #6285

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

miaulalala
Copy link
Contributor

@miaulalala miaulalala commented Aug 22, 2024

Fixes #167

To Do

  • Duplicate Members - create a single attendee and add the duplicate group ids to the MEMEBR property
  • Does it actually send invitation emails
  • use nc:groupname@group instead of mailto: prefix? doesn't work

@miaulalala miaulalala self-assigned this Aug 22, 2024
@miaulalala miaulalala added 2. developing Work in progress enhancement New feature request labels Aug 22, 2024
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.

Project coverage is 23.72%. Comparing base (d039b91) to head (0ec05ad).
Report is 31 commits behind head on main.

Files with missing lines Patch % Lines
.../components/Editor/Invitees/InviteesListSearch.vue 0.00% 25 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6285      +/-   ##
============================================
+ Coverage     23.54%   23.72%   +0.18%     
- Complexity      454      472      +18     
============================================
  Files           247      248       +1     
  Lines         11701    11775      +74     
  Branches       2213     2210       -3     
============================================
+ Hits           2755     2794      +39     
- Misses         8625     8661      +36     
+ Partials        321      320       -1     
Flag Coverage Δ
javascript 15.05% <0.00%> (-0.02%) ⬇️
php 59.59% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GVodyanov GVodyanov self-assigned this Nov 11, 2024
@miaulalala miaulalala marked this pull request as ready for review November 11, 2024 18:26
@SebastianKrupinski
Copy link
Contributor

Hey,

Found an issue, I am selecting a Group with 2 members "Group B"

Screenshot 2024-11-12 200218

But after selecting the "Group B" it only shows one attendee and says there is only one member in the group.

Screenshot 2024-11-12 200247

@miaulalala miaulalala removed their assignment Nov 13, 2024
@st3iny
Copy link
Member

st3iny commented Nov 14, 2024

Is User 1 in Group B and thus de-duplicated? Or maybe the missing user does not have an email address?

@SebastianKrupinski
Copy link
Contributor

Is User 1 in Group B and thus de-duplicated? Or maybe the missing user does not have an email address?

Good point! User 1 is not in Group B, but Contact 1 and User 1 do have the same email address. I will test again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress enhancement New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add contact groups as attendees for an event [$50]
4 participants