-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow inviting contact groups #6285
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6285 +/- ##
============================================
+ Coverage 23.54% 23.72% +0.18%
- Complexity 454 472 +18
============================================
Files 247 248 +1
Lines 11701 11775 +74
Branches 2213 2210 -3
============================================
+ Hits 2755 2794 +39
- Misses 8625 8661 +36
+ Partials 321 320 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Anna Larch <[email protected]>
ec8a47e
to
f464833
Compare
Is User 1 in Group B and thus de-duplicated? Or maybe the missing user does not have an email address? |
Good point! User 1 is not in Group B, but Contact 1 and User 1 do have the same email address. I will test again. |
Fixes #167
To Do
MEMEBR
propertyusedoesn't worknc:groupname@group
instead ofmailto:
prefix?