Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(embed): calendar header overlapping and adjust to compact design #6317

Merged
merged 1 commit into from
Sep 4, 2024
Merged

fix(embed): calendar header overlapping and adjust to compact design #6317

merged 1 commit into from
Sep 4, 2024

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Sep 4, 2024 •
edited
Loading

Before

image

After

grafik

@st3iny st3iny added 3. to review Waiting for reviews bug labels Sep 4, 2024
@st3iny st3iny added this to the v5.1.0 milestone Sep 4, 2024
@st3iny st3iny self-assigned this Sep 4, 2024
@st3iny
Copy link
Member Author

st3iny commented Sep 4, 2024

/backport to stable5.0

@backportbot backportbot bot added the backport-request A backport was requested for this pull request label Sep 4, 2024
@ChristophWurst
Copy link
Member

Wrong screenshots or why is it week vs month view?

@codecov Codecov
Copy link

codecov bot commented Sep 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.73%. Comparing base (0b7f8dc) to head (96fb2c7).
Report is 13 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #6317      +/-   ##
============================================
- Coverage     23.75%   23.73%   -0.03%     
  Complexity      454      454              
============================================
  Files           246      247       +1     
  Lines         11718    11731      +13     
  Branches       2220     2213       -7     
============================================
  Hits           2784     2784              
- Misses         8615     8627      +12     
- Partials        319      320       +1
Flag Coverage Δ
javascript 15.33% <ø> (-0.03%) ⬇️
php 59.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@st3iny
Copy link
Member Author

st3iny commented Sep 4, 2024

Wrong screenshots or why is it week vs month view?

Fixed the second screenshot.

@st3iny st3iny merged commit 4fba1c0 into main Sep 4, 2024
35 of 36 checks passed
@st3iny st3iny deleted the fix/embed/styling branch September 4, 2024 10:05
@backportbot backportbot bot mentioned this pull request Sep 4, 2024
Merged
@backportbot backportbot bot removed the backport-request A backport was requested for this pull request label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@miaulalala miaulalala miaulalala approved these changes

@hamza221 hamza221 hamza221 approved these changes

@tcitworld tcitworld Awaiting requested review from tcitworld tcitworld is a code owner

Assignees

@st3iny st3iny

Labels
3. to review Waiting for reviews bug
Projects
💌 📅 👥 Groupware team
Status: ☑️ Done
Milestone
v5.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@st3iny @ChristophWurst @miaulalala @hamza221