-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhanc: keep calendar always open #6322
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6322 +/- ##
=========================================
Coverage 23.54% 23.54%
Complexity 454 454
=========================================
Files 247 247
Lines 11700 11700
Branches 2203 2203
=========================================
Hits 2755 2755
Misses 8625 8625
Partials 320 320
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Nice! :) Also see #6324 for how we can improve the design for this as it looks a bit outdated atm |
@nimishavijay please have another look at the screenshot. In the appointment case, we cannot use the native datetimepicker, because the native one doesnt allow for the dropdown to be always open, because that is browser defined behavior. I tried to adopt the normal one, as much as i could, to your mockup in the other ticket. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks quite good! :)
-
One of the most important improvements UX-wise is: "disable dates for which no slots are available", is that possible to grey out the dates with no slots?added them to the general list, not to be delivered with this pr - The time zone picker doesn’t need a full heading, or just "Time zone", not "Select a time zone"
- The "Select a date and time slot" would be good to split, or if the time slots are shifted a bit down so it fits with the layout in @nimishavijay’s mockup
- Regarding the third column: Currently the vertical gap seems rather large, it could be reduced a little bit
-
There can be a larger gap for every hour as a little divider. In many cases like here, there would then be slots of 4 grouped together to get a better feeling for the time rather than a long list.added them to the general list, not to be delivered with this pr
Signed-off-by: greta <[email protected]>
Signed-off-by: greta <[email protected]>
Signed-off-by: greta <[email protected]>
0b4f46c
to
b373d5b
Compare
fixes #6321
requires: nextcloud-libraries/nextcloud-vue#6095