feat: disable autocompletion for event property field #6365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb
requested review from
miaulalala,
st3iny and
tcitworld
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6365 +/- ##
=========================================
Coverage 23.54% 23.54%
Complexity 454 454
=========================================
Files 247 247
Lines 11700 11700
Branches 2214 2202 -12
=========================================
Hits 2755 2755
- Misses 8624 8625 +1
+ Partials 321 320 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
I just added 8 events to my calendar, and my password manager asked me to unlock the vault for the auto suggestions for every event title. The password manager should do better, but autocompletion for the field seems to have little use and Google Calendar also uses autocomplete off for the event title.