Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(attachments): add missing file picker confirm #6383

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Oct 1, 2024

Nextcloud 29 (stable4.7) and below are not affected.

grafik

@st3iny st3iny added 3. to review Waiting for reviews bug labels Oct 1, 2024
@st3iny st3iny added this to the v5.1.0 milestone Oct 1, 2024
@st3iny st3iny self-assigned this Oct 1, 2024
@st3iny
Copy link
Member Author

st3iny commented Oct 1, 2024

/backport to stable5.0

@backportbot backportbot bot added the backport-request A backport was requested for this pull request label Oct 1, 2024
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 23.54%. Comparing base (08688c1) to head (df34ac0).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
.../components/Editor/Attachments/AttachmentsList.vue 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6383      +/-   ##
============================================
- Coverage     29.30%   23.54%   -5.77%     
+ Complexity      908      454     -454     
============================================
  Files           288      247      -41     
  Lines         13929    11701    -2228     
  Branches       2203     2202       -1     
============================================
- Hits           4082     2755    -1327     
+ Misses         9527     8626     -901     
  Partials        320      320              
Flag Coverage Δ
javascript 15.07% <0.00%> (-0.01%) ⬇️
php 59.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@st3iny st3iny force-pushed the fix/attachments/file-picker-confirm branch from 812233d to df34ac0 Compare October 1, 2024 14:56
@st3iny st3iny merged commit bc67247 into main Oct 1, 2024
33 of 35 checks passed
@st3iny st3iny deleted the fix/attachments/file-picker-confirm branch October 1, 2024 16:54
@backportbot backportbot bot removed the backport-request A backport was requested for this pull request label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
Status: ☑️ Done
Development

Successfully merging this pull request may close these issues.

3 participants