Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow adding self to shared event #6418

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

SebastianKrupinski
Copy link
Contributor

Resolves: #2659

Modified alreadyInvitedEmails result to NOT exclude the current user by default and to only include actual organize and attendees.

Copy link

codecov bot commented Oct 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 23.47%. Comparing base (436a9fe) to head (169582d).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/components/Editor/Invitees/InviteesList.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6418      +/-   ##
============================================
- Coverage     23.48%   23.47%   -0.01%     
  Complexity      454      454              
============================================
  Files           247      247              
  Lines         11705    11708       +3     
  Branches       2211     2212       +1     
============================================
  Hits           2749     2749              
- Misses         8636     8639       +3     
  Partials        320      320              
Flag Coverage Δ
javascript 15.05% <0.00%> (-0.01%) ⬇️
php 59.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaks the attendees tab on new events: TypeError: Cannot read properties of null (reading 'uri').

Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pleas squash and we are good to go.

@st3iny st3iny added the bug label Oct 17, 2024
@st3iny
Copy link
Member

st3iny commented Oct 17, 2024

Do we want to backport this (since the issue is from 2020)? Or is this too risky because of the recent shared calendar changes in server?

Signed-off-by: SebastianKrupinski <[email protected]>
@SebastianKrupinski SebastianKrupinski merged commit 7026ba2 into main Oct 31, 2024
33 of 35 checks passed
@SebastianKrupinski SebastianKrupinski deleted the fix/issue-2659-allow-adding-self branch October 31, 2024 01:54
@SebastianKrupinski
Copy link
Contributor Author

SebastianKrupinski commented Oct 31, 2024

Do we want to backport this (since the issue is from 2020)? Or is this too risky because of the recent shared calendar changes in server?

We can back port this a few versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
Status: ☑️ Done
Development

Successfully merging this pull request may close these issues.

Can't add myself to a shared event
3 participants