Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save full width of page on server #1386

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Save full width of page on server #1386

merged 1 commit into from
Aug 15, 2024

Conversation

Koc
Copy link
Contributor

@Koc Koc commented Jul 25, 2024 •
edited
Loading

📝 Summary

Currently we are storing "Full width" inside local storage. This means, that this setting not shares between users and browsers. Would be nice to make this setting persistent on db level like in Confluence.

🖼️ Screenshots

full-width-persistent.mp4

🚧 TODO

  • add tests after code review

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

Koc
Koc commented Jul 25, 2024
View reviewed changes
appinfo/routes.php Show resolved Hide resolved
@Koc Koc force-pushed the feature/save-full-width-on-server branch 5 times, most recently from e004d17 to 90efdf1 Compare July 27, 2024 23:07
@Koc Koc marked this pull request as ready for review July 27, 2024 23:11
@Koc Koc force-pushed the feature/save-full-width-on-server branch from 90efdf1 to 4527afb Compare July 27, 2024 23:15
@Koc
Copy link
Contributor Author

Koc commented Jul 27, 2024

I've added video to prove that it works. Please review @juliushaertl @mejo- @max-nextcloud and run pipeline

I will work on tests after initial review

@juliushaertl juliushaertl requested a review from mejo- July 29, 2024 06:11
@Koc Koc force-pushed the feature/save-full-width-on-server branch from 4527afb to 8f8e63d Compare August 3, 2024 11:36
@Koc
Copy link
Contributor Author

Koc commented Aug 3, 2024

rebased, fixed merge conflicts and disabled checkbox for users without edit permission. Please review

@Koc Koc force-pushed the feature/save-full-width-on-server branch from 8f8e63d to 99dd3ef Compare August 3, 2024 11:38
mejo-
mejo- approved these changes Aug 5, 2024
View reviewed changes
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for working on this @Koc ❤️

Code changes look good to me, I only have minor comments.

I'm in the process of migrating the frontend from vuex to pinia (#1398), so the frontend part will need some refactoring once this got merged. Sorry for the extra work 😬

appinfo/routes.php Show resolved Hide resolved
lib/Db/Page.php Show resolved Hide resolved
lib/Migration/Version021200Date20240725154232.php Show resolved Hide resolved
lib/Model/PageInfo.php Outdated Show resolved Hide resolved
mejo-
mejo- requested changes Aug 5, 2024
View reviewed changes
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, meant to request changes 😉

@Koc
Copy link
Contributor Author

Koc commented Aug 5, 2024

@mejo- all fine, I will do everything. No way to wait this changes before migration to Pinia? 🙏

@mejo-
Copy link
Member

mejo- commented Aug 5, 2024

@mejo- all fine, I will do everything. No way to wait this changes before migration to Pinia? 🙏

Sorry, pinia PR just got merged 😬

@Koc Koc force-pushed the feature/save-full-width-on-server branch 2 times, most recently from 6b3e294 to 06c95e6 Compare August 6, 2024 21:36
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 9, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@Koc Koc force-pushed the feature/save-full-width-on-server branch from 06c95e6 to 052682a Compare August 12, 2024 22:42
@Koc Koc mentioned this pull request Aug 12, 2024
Open
@Koc
Copy link
Contributor Author

Koc commented Aug 12, 2024

@mejo- @juliushaertl mates, how can I understand what thee root cause of Behat tests failure? How can I run this tests locally to debug failure?

@mejo-
Copy link
Member

mejo- commented Aug 13, 2024

@mejo- @juliushaertl mates, how can I understand what thee root cause of Behat tests failure? How can I run this tests locally to debug failure?

@Koc I'm pretty sure it's unrelated, but let's see. Given that your local Nextcloud instance is available under https://nextcloud.local, you can run the behat tests with make test-php-integration.

mejo-
mejo- requested changes Aug 13, 2024
View reviewed changes
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some minor comments and suggestions to fix the behat tests left. Really nice that you already provided behat tests 🫶

Cypress tests are already there and sufficient. The comment in

collectives/cypress/e2e/pages.spec.js

Line 262 in 63eba49

// Reload to check persistence with browser storage
could use an update though (just remove the "with browser storage" part).

src/stores/pages.js Show resolved Hide resolved
src/stores/pages.js Outdated Show resolved Hide resolved
tests/Integration/features/bootstrap/FeatureContext.php Outdated Show resolved Hide resolved
tests/Integration/features/bootstrap/FeatureContext.php Outdated Show resolved Hide resolved
@Koc Koc force-pushed the feature/save-full-width-on-server branch 3 times, most recently from f0ac972 to c83955e Compare August 14, 2024 22:34
@Koc
Save full width of page on server
39c51e6 
Signed-off-by: Konstantin Myakshin <[email protected]>
@Koc Koc force-pushed the feature/save-full-width-on-server branch from c83955e to 39c51e6 Compare August 14, 2024 22:47
@Koc
Copy link
Contributor Author

Koc commented Aug 14, 2024

There was a bug in the test and code 😄 . Now all green except Cypres

mejo-
mejo- approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice, thanks for your work @Koc ❤️

@mejo- mejo- merged commit cbeb5d4 into nextcloud:main Aug 15, 2024
49 of 53 checks passed
@Koc Koc deleted the feature/save-full-width-on-server branch August 15, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliushaertl juliushaertl juliushaertl left review comments

@mejo- mejo- mejo- approved these changes

Assignees
No one assigned
Labels
feedback-requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Koc @mejo- @juliushaertl