Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use search highlighting editor API from text #1412

Merged
merged 7 commits into from
Aug 18, 2024
Merged

feat: use search highlighting editor API from text #1412

merged 7 commits into from
Aug 18, 2024

Conversation

elzody
Copy link
Contributor

@elzody elzody commented Aug 11, 2024 •
edited
Loading

This PR includes tests for: #1381

📝 Summary

This PR changes to using the refactored API for search highlighting. Instead of using @nextcloud/event-bus, we use the proper API implemented on the editor itself for searching within the editor.

Related PR: nextcloud/text#6199

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@elzody elzody requested a review from mejo- August 11, 2024 16:40
@elzody elzody self-assigned this Aug 11, 2024
@elzody elzody force-pushed the refactor/search-highlight branch 2 times, most recently from b4d0c7d to 5ad5bd1 Compare August 12, 2024 17:57
@elzody elzody changed the title Refactor/search highlight feat: use search highlighting editor API from text Aug 12, 2024
mejo-
mejo- approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nice, only a small comment.

And I pushed one commit that fixes the scrollIntoView() when in edit mode. I hope you don't mind 😬

src/components/SearchDialog.vue Outdated Show resolved Hide resolved
@elzody elzody marked this pull request as ready for review August 13, 2024 19:03
elzody and others added 7 commits August 15, 2024 09:50
@elzody elzody linked an issue Aug 15, 2024 that may be closed by this pull request
Add test coverage for search highlight #1381
Closed
@mejo- mejo- merged commit c2ecf60 into main Aug 18, 2024
51 of 53 checks passed
@mejo- mejo- deleted the refactor/search-highlight branch August 18, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mejo- mejo- mejo- approved these changes

Assignees

@elzody elzody

Labels
2. developing enhancement New feature or request frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add test coverage for search highlight
2 participants
@elzody @mejo-