Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): Use flexbox to align editor container and search dialog #1474

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

mejo-
Copy link
Member

@mejo- mejo- commented Sep 11, 2024

This fixes stickyness of the search dialog to the bottom with long documents.

We have 2 or 3 elements in app-content-details: the page title, the editor, and optionally the search dialog. Page title and editor should align to the top, search dialog shall align to the bottom. Scroll container shall be in the editor.

First, the editor didn't take all space, so with a short document, the search dialog didn't align to the bottom. This was tried to fix by e918085, which had other unwanted side effects. So another attempt was bfb69b3. But the scroll container was wrong, so the search dialog moved out of the viewport with this approach. Instead of playing around more with position: sticky I decided to migrate it to flexbox instead.

I tested view and edit mode with sheet and full page width and with short documents and long documents. I also checked the loading skeletons for page header and page content.

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits

@mejo- mejo- added bug Something isn't working 3. to review labels Sep 11, 2024
@mejo- mejo- self-assigned this Sep 11, 2024
@mejo- mejo- merged commit 7daae34 into main Sep 13, 2024
50 checks passed
@mejo- mejo- deleted the fix/search_dialog_flex branch September 13, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants