fix(css): Use flexbox to align editor container and search dialog #1474
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes stickyness of the search dialog to the bottom with long documents.
We have 2 or 3 elements in
app-content-details
: the page title, the editor, and optionally the search dialog. Page title and editor should align to the top, search dialog shall align to the bottom. Scroll container shall be in the editor.First, the editor didn't take all space, so with a short document, the search dialog didn't align to the bottom. This was tried to fix by e918085, which had other unwanted side effects. So another attempt was bfb69b3. But the scroll container was wrong, so the search dialog moved out of the viewport with this approach. Instead of playing around more with
position: sticky
I decided to migrate it toflexbox
instead.I tested view and edit mode with sheet and full page width and with short documents and long documents. I also checked the loading skeletons for page header and page content.
🏁 Checklist
npm run lint
/npm run stylelint
/composer run cs:check
)