fix(CollectiveStorage): adjust getOwner to NC31
#1491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonas <[email protected]>
|
Wait... that change looks like it's only adding a return type to the function. Would this break with NC <= 30 because PHP does not yet support that syntax |
Exactly, it only adds the return type to be in line with the parent class on Nextcloud 31. I first thought it would then be incompatible with the parent classes on Nextcloud 30 and below, but manual testing and CI both proved me wrong. So should be good to be merged 😊 |
|
The change is backwards compatible as you can add return types for methods you inherit if the parent doesn't have any return type. |
blizzz
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)