fix: Prevent empty additional pages added when printing #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 flaky tests on run #292 ↗︎
Details:
|
|||||||||||||||||||||
| Test | ||
|---|---|---|
| Page > Creating a page from template > New page has template content |
Screenshot
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
max-nextcloud
approved these changes
Feb 10, 2023
susnux
force-pushed
the
fix/printing-extra-pages
branch
from
da7df01
to
504daea
Compare
|
I tried to reproduce the initial issue but failed. I'm currently working on getting the CI to pass again and then hope to try out the new merge queue feature with the remaining ones. |
No I observed this already before (and can reproduce this on different NC instances (all NC 25.0.3 or 26 beta 2) |
susnux
force-pushed
the
fix/printing-extra-pages
branch
from
504daea
to
de8d391
Compare
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/printing-extra-pages
branch
from
de8d391
to
21e4215
Compare
mejo-
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Currently an additional page is printed because of the height setting of the body tag,
this is fixed by setting the body height to fit the content.
🖼️ Screenshots
See page number(s):
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)