Manage members in app

[mejo-]

📝 Summary

This PR adds functionality to manage members for a collective inside the Collectives app. This removes our dependency on the Contacts app to do so.

It's possible to add and remove members and promote/demote their membership level.

• Resolves: Membership management #308
• Resolves: Improve user management with a growing number of collectives #244

🖼️ Screenshots

Searching for members	Changing membership level

🖼️ Screencast

🏡 Walkthrough creating a collective and managing its members
recording1.webm

🚧 TODO

• Cypress tests
• Don't allow to delete circle/group if current admin is member through it
• Always show option to leave collective (also to admins)
• Remove link to manage members in contacts
• Remove dependency checks on contacts app (and close Remove the notification "The contacts app is required to manage members" #779)
• Filtering out member groups doesn't work (groups have type 16 in circle response)

🏁 Checklist

• Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
• Sign-off message is added to all commits
• Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
• Documentation (README or documentation) has been updated or is not required

[mejo-]

@nextcloud/designers I'd appreciate feedback from you 😊 In particular on the icons used for admin/moderator/member levels and on the way the loading indicator icon is used.

[cypress]

Passing run #972 ↗︎

0

75

0

0

0

Details:

Manage members in app
Project: Collectives	Commit: 0d4ec5590c
Status: Passed	Duration: 04:10 💡
Started: Jul 27, 2023 3:27 PM	Ended: Jul 27, 2023 3:31 PM

_{This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.}

[marcoambrosini]

From a design perspective, I'm sorry but I don't have any constructive feedback to share. It looks very neat and easy to use, congrats!! :)

[juliushaertl]

Looks very nice, code also looks good, just a few commments from testing:

• The search results are not keyboard accessible
• The scroll in the modal seems a bit odd with two scroll areas:

• Maybe we can hide the "Add users, groups or circles ..." heading if the search is not triggered, the placeholder hint to search to add groups seems enough and the members also don't have a heading in the default state

[mejo-]

Maybe we can hide the "Add users, groups or circles ..." heading if the search is not triggered, the placeholder hint to search to add groups seems enough and the members also don't have a heading in the default state

@juliushaertl I would prefer to keep it. Talk behaves the same in the participants tab and I think its good to emphasize that you can search for new members to add.

[jancborchardt]

Yeah, looks nice design-wise! :)

[max-nextcloud]

Looking at the screencast it seems that people, circles and groups that are already in the collective are still listed in the sections to add members. I tried in talk and it seems to filter them out. I think that would be good.

[mejo-]

Looking at the screencast it seems that people, circles and groups that are already in the collective are still listed in the sections to add members. I tried in talk and it seems to filter them out. I think that would be good.

This is already fixed in the PR, but I didn't update the screencast ☺️

[nimishavijay]

Looks super nice! Only some minor points :)

• We generally don't use the "light" font weight very much, instead we use the regular font weight in --color-text-maxcontrast
• We could switch the icons for admin and moderator since the admin role has the most permissions
• Since there are 2 levels of permissions, there could be an simple explanation in a subline for all the roles to avoid confusion between admin and moderators
  • Admin: Manage collective members, view, edit, share and delete collectives
  • Moderators: View collectives, edit and share collectives if permitted
  • Members: View collectives, edit and share collectives if permitted

[mejo-]

Thanks @nimishavijay. I already changed the font color to --color-text-maxcontrast and switched the icons. For the level explanations this is a bigger thing and I'd like to postpone it, as I either would have to reimplement or extend NcActionButton.