fix: Make sure collectives own scroll area is used for menubar stickyness #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 failed and 2 flaky tests on run #1034 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Page > Creating a page from template > New page has template content |
Output
Screenshots
|
|
apps.spec.js • 1 failed test
| Test | Artifacts | |
|---|---|---|
| The apps > Collectives > allows creating a new collective |
Output
Screenshots
|
|
page-details.spec.js • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Page details > Displaying backlinks > Lists backlinks for a page |
Output
Screenshots
|
|
page-list.spec.js • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Page list > Page trash > allows to trash and restore page with subpage and attachment |
Output
Screenshots
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
|
I think the remaining cypress failures when loading a page could stabilize with nextcloud/text#4657 |
…ness Signed-off-by: Julius Härtl <[email protected]>
mejo-
force-pushed
the
bugfix/noid/viewer-scroll-area
branch
from
3542d9f
to
9503520
Compare
Fixes sticky titleform when viewing old page versions. Signed-off-by: Jonas <[email protected]>
|
Nice, thanks a lot @juliushaertl! Tested with Nextcloud 25, 26, 27 and master and all work well. Pushed a comment to fix stickyness of the titlebar when viewing old versions. |
mejo-
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As nextcloud/text#2832 introduced a max-height to properly handle
.text-editorbeing the scroll container for any viewer rendered editor, we will need to adapt the styling here slightly as collectives comes with its own scroll container.Note that the API for rendering the editor externally would solve that as this one doesn't bring its own scroll container https://github.com/nextcloud/text#%EF%B8%8F-integrate-text-in-your-app but needs more work to have feature parity for collectives.
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)