Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(RecentPagesWidget): Remove margin of slider button #862

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

mejo-
Copy link
Member

@mejo- mejo- commented Sep 5, 2023

πŸ“ Summary

Seems like recent upstream CSS changes introduced a margin for buttons. See screenshot.

πŸ–ΌοΈ Screenshots

🏚️ Before 🏑 After
2023-09-05T12:18:44,407621562+02:00 2023-09-05T12:19:35,628725173+02:00

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits

@mejo- mejo- added bug Something isn't working 3. to review labels Sep 5, 2023
@cypress
Copy link

cypress bot commented Sep 5, 2023

9 failed and 1 flaky tests on run #1112 β†—οΈŽ

9 70 0 0 Flakiness 1

Details:

fix(RecentPagesWidget): Remove margin of slider button
Project: Collectives Commit: 0e4ed928c8
Status: Failed Duration: 09:05 πŸ’‘
Started: Sep 7, 2023 11:57 AM Ended: Sep 7, 2023 12:06 PM
FailedΒ  pages.spec.js β€’ 1 failed test

View Output Video

Test Artifacts
Page > Using the reference picker > Supports selecting a page from a collective Test Replay Output Screenshots
FailedΒ  collective.spec.js β€’ 5 failed tests

View Output Video

Test Artifacts
Collective > name conflicts > creates collectives by picking circle Test Replay Output Screenshots
Collective > name conflicts > creates collectives for admins of corresponding circle Test Replay Output Screenshots
Collective > non ascii characters > can handle special chars in collective name Test Replay Output Screenshots
Collective > after creation > has all the ui elements Test Replay Output Screenshots
Collective > reloading works > Shows the name in the disabled titleform Test Replay Output Screenshots
FailedΒ  page-details.spec.js β€’ 1 failed test

View Output Video

Test Artifacts
Page details > Displaying backlinks > Lists backlinks for a page Test Replay Output Screenshots
FailedΒ  settings.spec.js β€’ 1 failed test

View Output Video

Test Artifacts
Settings > Collectives folder setting > Allows changing the collective user folder Test Replay Output Screenshots
FailedΒ  apps.spec.js β€’ 1 failed test

View Output Video

Test Artifacts
The apps > Disabled circles app does not break files view > Renders the default files list Test Replay Output Screenshots
FlakinessΒ  cypress/e2e/page-list.spec.js β€’ 1 flaky test

View Output Video

Test Artifacts
Page list > Page trash > allows to trash and restore page with subpage and attachment Test Replay Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@mejo- mejo- merged commit 67b7d3d into main Sep 11, 2023
37 of 46 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/slider_button_margin branch September 11, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants