Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Printing fixes #971

Merged
merged 6 commits into from
Oct 30, 2023
Merged

Printing fixes #971

merged 6 commits into from
Oct 30, 2023

Conversation

mejo-
Copy link
Member

@mejo- mejo- commented Oct 27, 2023 •
edited
Loading

📝 Summary

  • Provide "Export or print" action on readonly collectives
  • Fix link to print view on public shares
  • Don't print landing page widgets
  • Get rid of empty trailing page when printing
  • Fix detection of images in print view
  • Don't cut pages on Firefox
  • Get rid of background and border when printing

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation is not required

@mejo- mejo- added bug Something isn't working 3. to review labels Oct 27, 2023
@mejo-
fix(PageList): Provide "Export or print" action on readonly collectives
b0e2159 
Add page actions menu for landingpage in readonly collective.

Signed-off-by: Jonas <[email protected]>
@mejo-
fix(CollectiveActions): Fix link to print view on public shares
e4d88a1 
Sharetoken is needed for export link in public shares

Signed-off-by: Jonas <[email protected]>
@mejo-
fix(css): Don't print landing page widgets
b5fc0a4 
Signed-off-by: Jonas <[email protected]>
@mejo-
fix(css): Get rid of empty trailing page when printing
692b38f 
Signed-off-by: Jonas <[email protected]>
@mejo-
fix(CollectivePrint): Fix detection of images in the printed pages
4cdd36b 
Signed-off-by: Jonas <[email protected]>
@mejo-
fix(css): Fix CSS to print full page without border and background
e7b40fd 
Also resolves the problem with empty page before first page content on
Firefox.

Fixes: #542
Fixes: #543

Signed-off-by: Jonas <[email protected]>
@mejo- mejo- merged commit 9681cdc into main Oct 30, 2023
39 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/print branch October 30, 2023 15:13
@mejo- mejo- mentioned this pull request Oct 30, 2023
Closed
4 tasks
@pjrobertson
Copy link
Contributor

Awesome, thanks mejo!

Don't cut pages on Firefox

Seems like the bug I was previously experiencing. Looking forward to seeing this released :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliushaertl juliushaertl juliushaertl approved these changes

@susnux susnux Awaiting requested review from susnux

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud

Assignees
No one assigned
Labels
3. to review bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Printing: Collective title always on blank first page Improve printing layout
3 participants
@mejo- @pjrobertson @juliushaertl