Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update app to be formally compatible with NC 31 #2511

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Update app to be formally compatible with NC 31 #2511

merged 2 commits into from
Sep 20, 2024

Conversation

christianlupus
Copy link
Collaborator

Topic and Scope

This just marks the app as compatible with NC 31

Concerns/issues

No RC yet published.

Formal requirements

There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.

  • I did check that the app can still be opened and does not throw any browser logs
  • I created tests for newly added PHP code (check this if no PHP changes were made)
  • I updated the OpenAPI specs and added an entry to the API changelog (check if API was not modified)
  • I notified the matrix channel if I introduced an API change

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 19, 2024 •
edited
Loading

Test Results

   12 files    584 suites   1m 37s ⏱️
  575 tests   575 ✅ 0 💤 0 ❌
2 300 runs  2 299 ✅ 1 💤 0 ❌

Results for commit 7685e6f.

♻️ This comment has been updated with latest results.

@christianlupus christianlupus marked this pull request as ready for review September 19, 2024 22:06
@christianlupus
Copy link
Collaborator Author

/approve

nextcloud-cookbook-bot
nextcloud-cookbook-bot approved these changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@nextcloud-cookbook-bot nextcloud-cookbook-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approved by GitHub action on behalf of /approve

@christianlupus christianlupus merged commit 2a1b0aa into master Sep 20, 2024
31 checks passed
@christianlupus christianlupus deleted the maintenance/new-server-version branch September 20, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nextcloud-cookbook-bot nextcloud-cookbook-bot nextcloud-cookbook-bot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christianlupus @nextcloud-cookbook-bot