Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle rootless redis-session.ini #2001

Closed
wants to merge 1 commit into from

Conversation

tlvince
Copy link

@tlvince tlvince commented Jun 1, 2023

Warns the user to mount redis-session.ini when running not running as root.

If this looks good, I'll duplicate to the other entrypoint scripts.

Closes #763.

@tlvince tlvince force-pushed the fix/non-root branch 3 times, most recently from 7458d96 to 7987a5a Compare June 1, 2023 14:52
@dvaerum
Copy link
Contributor

dvaerum commented Jun 14, 2023

Hey @tlvince, you should make the change to ./entrypoint.sh not ./25/apache/entrypoint.sh and when before testing run the ./update.sh script.

I have been doing something like this to run a quick test 🙂

./update.sh && docker build --tag 'nextcloud:25-fpm' 25/fpm && docker run --rm nextcloud:25-fpm

@tlvince
Copy link
Author

tlvince commented Jun 15, 2023

Ah, great! Updated, thanks.

@J0WI
Copy link
Contributor

J0WI commented Sep 14, 2023

Well, it's not a fix just a more verbose info. It shouldn't hurt to add it but it needs rebasing.

@tlvince tlvince closed this Sep 15, 2023
@tlvince tlvince deleted the fix/non-root branch September 15, 2023 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduced redis session handler does not work with non-root images
3 participants